[PATCH weston] remove warning of ivisurface reassign on the ivilayer

[Pekka Paalanen]

On Thu,  3 Mar 2016 19:56:09 +0900
Wataru Natsume <wataru_natsume at xddp.denso.co.jp> wrote:

> From: Wataru Natsume <WATARU_NATSUME at xddp.denso.co.jp>
> 
> The warning of ivisurface reassign can be removed. Current ivi_layout_layer_add_surface() removes the ivisurface from its previous ivilayer and returns sucess.
> 
> Signed-off-by: Wataru Natsume <WATARU_NATSUME at xddp.denso.co.jp>
> ---
>  ivi-shell/ivi-layout.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index f7c4f27..7da229e 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -2418,7 +2418,13 @@ ivi_layout_layer_add_surface(struct ivi_layout_layer *ivilayer,
>  	}
>  
>  	if (addsurf->on_layer == ivilayer) {
> -		weston_log("ivi_layout_layer_add_surface: addsurf is already available\n");
> +		/*
> +		 * Just disable the check to avoid that this warning occurred when surface
> +		 * position moves in the same layer.
> +		 * This code will get rewritten anyway when views are added in current design
> +		 * as a tying object.
> +		 */
> +		/* weston_log("ivi_layout_layer_add_surface: addsurf is already available\n"); */
>  		return IVI_SUCCEEDED;
>  	}
>  

Hi Natsume-san,

I took the liberty of editing this patch to just remove the comments
altogether. The comment would be better placed in the commit message,
so I edited that too.

Pushed:
   7e7f793..9d8b441  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160304/b3ba9114/attachment.sig>