[PATCH weston v5] input: use doubles in the interfaces to notify of input events

[Pekka Paalanen]

On Tue, 22 Mar 2016 16:53:14 +0200
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> This patch is a further step in the wl_fixed_t internal sanitization.
> It changes the notify_* functions to take doubles instead of wl_fixed_t
> but does not change how these are stored in the various input structs
> yet, except for weston_pointer_axis_event.
> However this already allows to remove all wl_fixed_t usage in places
> like the libinput or the x11 backend.
> 
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
> 
> v5: fixed wl_fixed_t usage in desktop-shell's do_zoom()
> 
>  desktop-shell/shell.c    |  6 +++---
>  src/compositor-rdp.c     | 12 +++--------
>  src/compositor-wayland.c | 56 +++++++++++++++++++++++++++++-------------------
>  src/compositor-x11.c     | 22 +++++++++----------
>  src/compositor.c         | 12 +++++------
>  src/compositor.h         | 12 +++++------
>  src/input.c              | 15 +++++++------
>  src/libinput-device.c    | 26 ++++++++++------------
>  src/screen-share.c       |  5 +++--
>  9 files changed, 86 insertions(+), 80 deletions(-)
> 

Hi,

as discussed in IRC, I almost pushed this patch after fixing the stray
parenthesis, only to find out it breaks cursor tracking on x11-backend
when the cursor leaves and enters the x11 window. For good measure, you
can (must?) mix zooming with it.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160322/07b6ad90/attachment.sig>