[Spice-devel] Questions about experimental Spice compositor rebase

[Yury Shvedov]

Hi!

Very thank you, but we know and already fixed that =)

On 03/24/2016 06:40 PM, Christophe Fergeau wrote:
> Hey,
>
> On Sun, Feb 28, 2016 at 03:36:58PM +0100, Fabio Fantoni wrote:
>> I did fast build tests, I fixed one my mistake in Makefile.am and after I
>> had this error:
>>> src/spice/weston_basic_event_loop.h:27:31: fatal error: weston/compositor.h: No such file or directory
>> I fixed with this even if I'm not sure it is correct:
>> https://github.com/Fantu/compositor-spice/commit/92f8eeb50e593a489e23b5ddeb38edf0985603f2
>>
>> Now I had these errors:
>>> src/spice/compositor-spice.c: In function
>>> 'spice_output_start_repaint_loop':
>>> src/spice/compositor-spice.c:66:5: warning: 'start' is deprecated
>>> [-Wdeprecated-declarations]
>>>      c->worker->start(c->worker);
>>>      ^
>>> In file included from /usr/include/spice-server/spice.h:26:0,
>>>                  from src/spice/compositor-spice.c:27:
>>> /usr/include/spice-server/spice-qxl.h:46:12: note: declared here
>>>      void (*start)(QXLWorker *worker) SPICE_GNUC_DEPRECATED;
>>>             ^
>>> src/spice/compositor-spice.c: In function 'on_wakeup':
>>> src/spice/compositor-spice.c:118:5: warning: 'wakeup' is deprecated
>>> [-Wdeprecated-declarations]
>>>      c->worker->wakeup(c->worker);
>>>      ^
>>> In file included from /usr/include/spice-server/spice.h:26:0,
>>>                  from src/spice/compositor-spice.c:27:
>>> /usr/include/spice-server/spice-qxl.h:44:12: note: declared here
>>>      void (*wakeup)(QXLWorker *worker) SPICE_GNUC_DEPRECATED;
>>>             ^
>>> src/spice/compositor-spice.c: In function 'spice_destroy':
>>> src/spice/compositor-spice.c:262:5: warning: 'stop' is deprecated
>>> [-Wdeprecated-declarations]
>>>      c->worker->stop (c->worker);
>>>      ^
>>> In file included from /usr/include/spice-server/spice.h:26:0,
>>>                  from src/spice/compositor-spice.c:27:
>>> /usr/include/spice-server/spice-qxl.h:47:12: note: declared here
>>>      void (*stop)(QXLWorker *worker) SPICE_GNUC_DEPRECATED;
>>>             ^
>> About spice deprecated functions I did a fast search and I found spice-gtk
>> api docs:
>> http://www.spice-space.org/spice-gtk.html
>> but not the spice-server one.
>> @Spice developers: can someone tell me where I can found needed spice-server
>> api documentation to make update faster and easier as possible please?
> Note that these deprecated functions are not triggering errors, but are
> just warnings.
> These were deprecated a while ago in
> https://cgit.freedesktop.org/spice/spice/commit/?id=c04d60631e91ce9f61d417fb017d94d9a1e78dc1
>
> The replacement for
> c->worker->start(c->worker);
> should be spice_qxl_start(c->worker); (but this specific one was later replaced
> with spice_server_vm_start())
>
> Christophe

-- 
Kind Regards,
Yury Shvedov