[PATCH wayland-web] Updated build instructions for wayland-protocols and libwacom

Wed Mar 9 17:31:01 UTC 2016

On Tue, Mar 8, 2016 at 11:49 PM, Bryce Harrington <bryce at osg.samsung.com>
wrote:

> On Wed, Mar 09, 2016 at 12:54:11PM +1000, Peter Hutterer wrote:
> > On Tue, Mar 08, 2016 at 06:39:43PM -0800, Bill Spitzak wrote:
> > > On Tue, Mar 8, 2016 at 6:12 PM, Peter Hutterer <
> peter.hutterer at who-t.net>
> > > wrote:
> > >
> > > > On Fri, Mar 04, 2016 at 10:16:30PM -0800, spitzak at gmail.com wrote:
> > > > > From: Bill Spitzak <spitzak at gmail.com>
> > > > >
> > > > > The Mint instructions have been tested, I had to guess at the
> Ubuntu12
> > > > > instructions as I no longer have that machine.
> > > >
> > > > fwiw, I do question the need for build instructions for a new
> graphics
> > > > stack
> > > > on a >3 year old release.
> > >
> > > I am unsure, but for a lot of people trying to use work machines they
> are
> > > stuck with such old versions. I know my previous job (Oblong
> Industries) is
> > > still using this version of Ubuntu. Here at Dreamworks they are even
> older
> > > RHEL6 and I cannot compile it at all.
> >
> > I don't doubt that some people are trying to compile it, but as I said, I
> > question the need to provide build instructions (which look official when
> > they're on the wayland website). especially if they're untested.
>
> Personally I don't see a problem with it, it's just keeping already
> published documentation updated as stuff changes.
>

I think it should be kept as it contains the hair needed to get Mesa to
compile, which was by far the biggest sticking point in getting Wayland
working. That problem may come up again if Wayland is changed to depend on
a bleeding-edge Mesa dependency.

> That said, I agree with 12.04 we're probably pretty deep into the long
> tail for users.  Especially with 16.04 coming out next month I wouldn't
> see a problem just dropping the 12.04 directions at this point.
>
> Bryce
>
> > > > ---
> > > > >  mint17.html      | 21 ++++++++++++++++++---
> > > > >  ubuntu12.04.html | 13 +++++++++++--
> > > > >  2 files changed, 29 insertions(+), 5 deletions(-)
> > > > >
> > > > > diff --git a/mint17.html b/mint17.html
> > > > > index ae1c5a8..f32ef9e 100644
> > > > > --- a/mint17.html
> > > > > +++ b/mint17.html
> > > > > @@ -12,7 +12,7 @@
> > > > >  Building Weston on Linux Mint 17</h1>
> > > > >
> > > > >  <p>The following sequence of commands successfully built Weston
> and
> > > > > -XWayland on a Linux Mint 17 Cinnamon system, on October 28 2014.
> These
> > > > > +XWayland on a Linux Mint 17.3 Cinnamon system, on March 2, 2016.
> These
> > > > >  commands will probably work on any system based on Ubuntu
> 14.04.</p>
> > > > >
> > > > >  <p>This is considerably easier than earlier systems as the
> distributed
> > > > > @@ -32,7 +32,7 @@ mkdir -p $ACLOCAL_PATH
> > > > >
> > > > >  <span class="comment"># libwayland:</span>
> > > > >
> > > > > -apt install libffi-dev libexpat-dev
> > > > > +apt install libffi-dev libexpat-dev libxml2-dev
> > > > >  apt install doxygen xmlto <span class="comment"># or use
> > > > --disable-documentation</span>
> > > > >
> > > > >  git clone git://anongit.freedesktop.org/wayland/wayland
> > > > > @@ -41,10 +41,25 @@ cd wayland
> > > > >  make -j 9 && make install
> > > > >  cd ..
> > > > >
> > > > > +<span class="comment"># wayland-protocols:</span>
> > > > > +
> > > > > +git clone git://anongit.freedesktop.org/wayland/wayland-protocols
> > > > > +cd wayland-protocols
> > > > > +./autogen.sh --prefix=$WLD
> > > > > +make -j 9 && make install
> > > > > +cd ..
> > > > > +
> > > > >  <span class="comment"># libinput:</span>
> > > > >
> > > > >  apt install libmtdev-dev libudev-dev libevdev-dev
> > > > >
> > > > > +<span class="comment"># newer version of libwacom is needed than
> in apt
> > > > > +apt install libgudev-1.0-dev
> > > > > +git clone git://git.code.sf.net/p/linuxwacom/libwacom
> > > > > +cd libwacom
> > > > > +make -j 9 && make install
> > > > > +cd ..
> > > > > +
> > > > >  git clone git://anongit.freedesktop.org/wayland/libinput
> > > > >  cd libinput
> > > > >  ./autogen.sh --prefix=$WLD
> > > > > @@ -163,7 +178,7 @@ cd xserver
> > > > >  ./autogen.sh --prefix=$WLD --disable-docs --disable-devel-docs \
> > > > >    --enable-xwayland --disable-xorg --disable-xvfb --disable-xnest
> \
> > > > >    --disable-xquartz --disable-xwin
> > > > > -make && make install
> > > > > +make -j 9 && make install
> > > >
> > > > what's the reason we hardcode -j9 everywhere instead of relying on
> users to
> > > > set their MAKEFLAGS?
> > > >
> > >
> > > It might work now for Mint. I don't think Mesa compiled correctly with
> > > parallel make so I had to leave it out of that one.
> >
> > I'd say override it there with a forced -j1 and file a bug upstream.
> >
> > > Would you think it best to insert the setenv in the Mint instructions?
> >
> > No, you don't insert a setenv, you can point out that people should have
> > that set, but don't override their local settings. They may have other
> > makeflags that matter.
>

Actually it was Wayland that had a problem with parallel make, the
documentation failed, but I fixed that some time ago.

I believe Mesa's problem was that you sometimes had to do a "git clean" in
order to get a correct recompilation, but that would not affect these
instructions.

Therefore I agree that removing the make flags is a good idea. It currently
kind of implies they are required. I would at least put in a commented out
line setting them to prove they work (projects that cannot be built
parallel are not uncommon and without this people may assume it does not
work).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160309/3f1afe57/attachment-0001.html>