[PATCH weston 2/8] compositor-drm: Write a name in the mode generated from a modeline

Yong Bakos junk at humanoriented.com
Mon May 2 23:09:13 UTC 2016


On May 2, 2016, at 4:40 PM, Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com> wrote:
> 
> The current behaviour leaves the name empty, making it somewhat harder
> to determine the characteristics of this mode from a debugger.
> 
> Signed-off-by: Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com>

Hi Emmanuel,
One long line I noticed, below.

yong


> ---
> src/compositor-drm.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/src/compositor-drm.c b/src/compositor-drm.c
> index 7c5e1af..ea118fa 100644
> --- a/src/compositor-drm.c
> +++ b/src/compositor-drm.c
> @@ -2121,6 +2121,8 @@ parse_modeline(const char *s, drmModeModeInfo *mode)
> 	else
> 		return -1;
> 
> +	snprintf(mode->name, sizeof mode->name, "%dx%d@%.3f", mode->hdisplay, mode->vdisplay, fclock);

	snprintf(mode->name, sizeof mode->name, "%dx%d@%.3f", mode->hdisplay,
		 mode->vdisplay, fclock);


> +
> 	return 0;
> }
> 
> -- 
> 2.8.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list