[PATCH weston v3 06/17] compositor: constify weston_surface_build_buffer_matrix()

Bryce Harrington bryce at osg.samsung.com
Thu May 5 00:34:22 UTC 2016


On Tue, Apr 26, 2016 at 03:50:58PM +0300, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Makes it easier to see that it does not change weston_surface state
> implicitly.
> 
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Sure, LGTM:

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

> ---
>  src/compositor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/compositor.c b/src/compositor.c
> index 5500197..491b333 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -2708,10 +2708,10 @@ weston_surface_commit_subsurface_order(struct weston_surface *surface)
>  }
>  
>  static void
> -weston_surface_build_buffer_matrix(struct weston_surface *surface,
> +weston_surface_build_buffer_matrix(const struct weston_surface *surface,
>  				   struct weston_matrix *matrix)
>  {
> -	struct weston_buffer_viewport *vp = &surface->buffer_viewport;
> +	const struct weston_buffer_viewport *vp = &surface->buffer_viewport;
>  	double src_width, src_height, dest_width, dest_height;
>  
>  	weston_matrix_init(matrix);
> -- 
> 2.7.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list