[PATCH wayland v2] scanner: Add version argument to wayland-scanner

[Pekka Paalanen]

On Thu, 5 May 2016 17:06:43 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Thu, May 05, 2016 at 06:34:54PM -0500, Yong Bakos wrote:
> > On May 5, 2016, at 10:27 AM, Armin Krezović <krezovic.armin at gmail.com> wrote:  
> > > 
> > > This adds a command line argument to print wayland-scanner version.
> > > 
> > > It also makes wayland-scanner emit a comment with wayland library
> > > version to every file it generates.
> > > 
> > > v2: separate variable definitions into their own lines and remove
> > >    old style "version" argument
> > > 
> > > Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> > > Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> > > Tested-by: Yong Bakos <ybakos at humanoriented.com>
> > > Signed-off-by: Armin Krezović <krezovic.armin at gmail.com>  

Hi Armin,

here it is not that important, but usually you need to reconsider if
any previously given tags still apply on a new revision of a patch.
Often it is still beneficial to keep them, but note that they were for
v1. It could be done like this:
https://cgit.freedesktop.org/wayland/weston/commit/?id=830b7882f1d4674d920a9b260bd3cad7c62a110e

The order of tags is significant if there were changes made in between.

> > 
> > Hi Armin,
> > Looks good to me, and I also re-tested.
> > (Just a thought: should this be two separate patches, since we're
> > adding both the version arg _and_ adding a version comment in the
> > generated files? I know that it's "just a comment" so it's trivial,
> > and I'm not suggesting that it be broken apart.)  
> 
> I don't think it matters, the patch is straightforward enough as is;
> I think it's fine to land now.

Ok, cool.

Pushed:
   08bda63..721c91c  master -> master


Thanks,
pq

> > > ---
> > > src/scanner.c | 26 ++++++++++++++++++++++++--
> > > 1 file changed, 24 insertions(+), 2 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160506/6b0f52a9/attachment-0001.sig>