[PATCH wayland 0/1] connection: Move wl_interface_equal to util
Yong Bakos
junk at humanoriented.com
Sun May 8 13:44:07 UTC 2016
From: Yong Bakos <ybakos at humanoriented.com>
First, please forgive me if I'm making naive changes. I do look at the
history of things before submitting such patches (I'm no maverick), and I
appreciate the time it takes to tell me "no".
During my documentation journey I found wl_interface_equal buried in the
middle of map, connection and closure related function prototypes in
wayland-private. In addition, the implementation is in connection.c, and
while there is a call site there, wayland-client and wayland-server also
call wl_interface_equal. It's indeed a utility function and not
connection-specific; connection, wayland-client and wayland-server include
wayland-util anyway; so, this patch argues for moving the implementation to
wayland-util.
Should this function be private at all? I understand the value of keeping
the API as minimal as possible, but I recall some recent patches doing a
lot of interface->name comparisons.
Thanks for considering,
yong
Yong Bakos (1):
connection: Move wl_interface_equal to util
src/connection.c | 13 -------------
src/wayland-private.h | 8 ++++----
src/wayland-util.c | 13 +++++++++++++
3 files changed, 17 insertions(+), 17 deletions(-)
--
2.7.2
More information about the wayland-devel
mailing list