[PATCH libinput] gestures: don't send swipe gestures when gestures are disabled

Hans de Goede hdegoede at redhat.com
Fri May 13 08:46:35 UTC 2016


Hi,

On 13-05-16 02:29, Peter Hutterer wrote:
> Introduced in 6ad303b as part of an code flow optimization, causing any 3+
> finger gesture to be posted as swipe gesture, even when gestures are disabled.
> However, the event is filtered in the higher levels with a bug message printed
> to the log.
>
> Don't post swipe gestures for devices where gestures are disabled.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=95314
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Makes sense:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


> ---
>  src/evdev-mt-touchpad-gestures.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
> index 7bbd3b8..2a804e7 100644
> --- a/src/evdev-mt-touchpad-gestures.c
> +++ b/src/evdev-mt-touchpad-gestures.c
> @@ -248,7 +248,7 @@ tp_gesture_handle_state_none(struct tp_dispatch *tp, uint64_t time)
>  		if (ntouches == 2)
>  			return GESTURE_STATE_SCROLL;
>  		else
> -			return GESTURE_STATE_SWIPE;
> +			return GESTURE_STATE_NONE;
>  	}
>
>  	first = touches[0];
>


More information about the wayland-devel mailing list