[PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

[Pekka Paalanen]

On Tue, 17 May 2016 12:17:45 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Mon, 16 May 2016 16:29:18 +0200
> Armin Krezović <krezovic.armin at gmail.com> wrote:
> 
> > On 10.05.2016 16:10, Pekka Paalanen wrote:  
> > > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > 
> > > a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into
> > > a view list.
> > > 
> > > It looks like weston_surface::output's comment about surface list does
> > > not apply to view list. Still, many places assume weston_surface::output
> > > is not NULL when processing "visible" surfaces, e.g. those reachable via
> > > the view list.
> > > 
> > > The comment on weston_view::output is updated, but I could not figure
> > > out the actual relationship between that and being on the view list.
> > > 
> > > weston_view::link is documented to be in weston_compositor::view_list,
> > > and weston_compositor::view_list is documented to contain weston_views.
> > >     
> > 
> > It is always nice to see someone documenting the code. I've been banging
> > my head lately to understand the codebase, and the currently present
> > comments really help there.
> > 
> > With the issue noted below fixed, this patch is:
> > 
> > Reviewed-by: Armin Krezović <krezovic.armin at gmail.com>
> >   
> > > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > ---
> > >  src/compositor.h | 7 +++----
> > >  1 file changed, 3 insertions(+), 4 deletions(-)

> IOW, did not find a connection between link and output there.
> 
> 
> I think I'll tweak the comments in these two patches a bit, and maybe
> push then.

Comments tweaked a bit, and both pushed:
   901ac32..130ae6e  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160517/a9773986/attachment.sig>