[PATCH] ivi-layout: Initialize surface source rectange to 1x1

[Yong Bakos]

On May 17, 2016, at 3:58 AM, mateuszx.potrola at intel.com wrote:
> 
> From: Mateusz Polrola <mateuszx.potrola at intel.com>
> 
> If surface will be set to visible before its source rectangle will
> be defined it will be displayed in its orginal size.
> This is because initial setting of destination rectangle to 1x1 is
> not causing surface resize and because source rectangle is 0x0
> appropiate transformation matrix is not calculated
> 
> Signed-off-by: Mateusz Polrola <mateuszx.potrola at intel.com>

Hi Mateusz,
Minor nit: would be nice to see [PATCH weston] in the subject line. See:
https://lists.freedesktop.org/archives/wayland-devel/2016-March/027722.html

Regarding the patch,


> ---
> ivi-shell/ivi-layout.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 1601787..ef7ee02 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -250,6 +250,9 @@ init_surface_properties(struct ivi_layout_surface_properties *prop)
> 	 */
> 	prop->dest_width = 1;
> 	prop->dest_height = 1;
> +
> +	prop->source_width = 1;
> +	prop->source_height = 1;
> }

Minor nit: I wouldn't use a blank line there.
Should there be a condition around this to only set the source
width/height to 1 if they're both 0?

yong


> 
> /**
> -- 
> 2.1.0
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Christian Lamprechter
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel