[PATCH wayland-protocols v2 4/7] xdg-shell: Improve error enum formatting some

[Yong Bakos]

On May 11, 2016, at 12:50 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> The long lines stood out, break them by putting the summary on its own
> line.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Reviewed-by: Mike Blumenkrantz <zmike at osg.samsung.com>

This v2 is again
Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

At some point I want to gently propose that all protocol docs place the summary
attributes on their own line, for a) consistency and b) to decouple documentation
changes from other parameter attributes in the commit history.

yong


> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index 0d31ca5..d539c1f 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -37,10 +37,14 @@
> 
>     <enum name="error">
>       <entry name="role" value="0" summary="given wl_surface has another role"/>
> -      <entry name="defunct_surfaces" value="1" summary="xdg_shell was destroyed before children"/>
> -      <entry name="not_the_topmost_popup" value="2" summary="the client tried to map or destroy a non-topmost popup"/>
> -      <entry name="invalid_popup_parent" value="3" summary="the client specified an invalid popup parent surface"/>
> -      <entry name="invalid_surface_state" value="4" summary="the client provided an invalid surface state"/>
> +      <entry name="defunct_surfaces" value="1"
> +	     summary="xdg_shell was destroyed before children"/>
> +      <entry name="not_the_topmost_popup" value="2"
> +	     summary="the client tried to map or destroy a non-topmost popup"/>
> +      <entry name="invalid_popup_parent" value="3"
> +	     summary="the client specified an invalid popup parent surface"/>
> +      <entry name="invalid_surface_state" value="4"
> +	     summary="the client provided an invalid surface state"/>
>     </enum>
> 
>     <request name="destroy" type="destructor">
> -- 
> 2.5.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel