[PATCH libinput 2/3] touchpad: disable cursor jump detection for Wacom tablets

[Hans de Goede]

Hi,

On 18-05-16 09:02, Peter Hutterer wrote:
> We haven't seen jumps on Wacom tablets yet and they cause error messages in
> most of the tests. litest uses a scaling approach for most events, so a finger
> move that moves from 30% to 80% of the touchpad with can easily trigger a jump
> on a Wacom tablet due to its physical size.
>
> Rather than having to fix up all tests for the larger size (and potentially
> cover some other bugs) simply disable this test for Wacom tablets.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans



> ---
>  src/evdev-mt-touchpad.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
> index c854043..b582f65 100644
> --- a/src/evdev-mt-touchpad.c
> +++ b/src/evdev-mt-touchpad.c
> @@ -913,6 +913,12 @@ tp_detect_jumps(const struct tp_dispatch *tp, struct tp_touch *t)
>  	double dx, dy;
>  	const int JUMP_THRESHOLD_MM = 20;
>
> +	/* We haven't seen pointer jumps on Wacom tablets yet, so exclude
> +	 * those.
> +	 */
> +	if (tp->device->model_flags & EVDEV_MODEL_WACOM_TOUCHPAD)
> +		return false;
> +
>  	if (t->history.count == 0)
>  		return false;
>
>