[PATCH weston v2 1/3] compositor-x11: add assert to avoid misuse of x11_backend_deliver_button_event

Benoit Gschwind gschwind at gnu-log.net
Wed May 18 19:32:11 UTC 2016


The x11_backend_deliver_button_event can be called with any
xcb_generic_event. The assert check if the call is done with the
expected events.

Signed-off-by: Benoit Gschwind <gschwind at gnu-log.net>
---
 src/compositor-x11.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/compositor-x11.c b/src/compositor-x11.c
index 629b5f3..19ff9af 100644
--- a/src/compositor-x11.c
+++ b/src/compositor-x11.c
@@ -1045,6 +1045,9 @@ x11_backend_deliver_button_event(struct x11_backend *b,
 	struct x11_output *output;
 	struct weston_pointer_axis_event weston_event;
 
+	assert(event->response_type == XCB_BUTTON_PRESS ||
+	       event->response_type == XCB_BUTTON_RELEASE);
+
 	output = x11_backend_find_output(b, button_event->event);
 	if (!output)
 		return;
-- 
2.7.3



More information about the wayland-devel mailing list