[PATCH wayland] event-loop: Make transitive include explicit

Jonas Ådahl jadahl at gmail.com
Fri May 20 03:14:13 UTC 2016


On Thu, May 19, 2016 at 12:39:13PM -0400, Yong Bakos wrote:
> On May 17, 2016, at 2:32 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
> > 
> > On Mon, May 16, 2016 at 12:05:39PM -0600, Yong Bakos wrote:
> >> From: Yong Bakos <ybakos at humanoriented.com>
> >> 
> >> The explicit inclusion of wayland-server.h hides the real dependency, which
> >> is wayland-server-core.h.
> >> 
> >> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> > 
> > Reviewed-by: Jonas Ådahl <jadahl at gmail.com>
> 
> Thanks for the review. But to be sure, this change wouldn't affect
> backward-compatibility, would it?

The patch only touches an internal C file, changing the way it includes
its own header files. So I don't think this affects any backward
compatibility.


Jonas

> 
> yong
> 
> 
> >> ---
> >> src/event-loop.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/src/event-loop.c b/src/event-loop.c
> >> index ea27b69..11a9bf2 100644
> >> --- a/src/event-loop.c
> >> +++ b/src/event-loop.c
> >> @@ -37,7 +37,7 @@
> >> #include <sys/timerfd.h>
> >> #include <unistd.h>
> >> #include "wayland-private.h"
> >> -#include "wayland-server.h"
> >> +#include "wayland-server-core.h"
> >> #include "wayland-os.h"
> >> 
> >> struct wl_event_loop {
> >> -- 
> >> 2.7.2
> >> 
> >> _______________________________________________
> >> wayland-devel mailing list
> >> wayland-devel at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 


More information about the wayland-devel mailing list