[PATCH weston 1/6] Export weston_compositor_xkb_init, as required for libweston users

[Pekka Paalanen]

On Tue, 24 May 2016 19:59:05 +0300
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> ---
>  src/input.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/input.c b/src/input.c
> index 8fe898c..c6cdedd 100644
> --- a/src/input.c
> +++ b/src/input.c
> @@ -2277,7 +2277,7 @@ bind_seat(struct wl_client *client, void *data, uint32_t version, uint32_t id)
>  }
>  
>  #ifdef ENABLE_XKBCOMMON
> -int
> +WL_EXPORT int
>  weston_compositor_xkb_init(struct weston_compositor *ec,
>  			   struct xkb_rule_names *names)
>  {
> @@ -2442,7 +2442,7 @@ weston_compositor_build_global_keymap(struct weston_compositor *ec)
>  	return 0;
>  }
>  #else
> -int
> +WL_EXPORT int
>  weston_compositor_xkb_init(struct weston_compositor *ec,
>  			   struct xkb_rule_names *names)
>  {

Hi,

it is strange to have to export just the init function but not the
destroy function, though that is how it is being used currently.

In the future, something should be rearranged here. Either also export
the destroy function and do not call it automatically in
weston_compositor_destroy(), or un-export the init function and pass
the xkb config into libweston.

I think we should start collecting a TODO of these things. To that end,
I started this:
https://phabricator.freedesktop.org/T7439
And filed this little issue under it.

Therefore:
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160525/42c275cb/attachment.sig>