[PATCH weston v3 4/8] desktop-shell: Support tracking active surfaces

[Pekka Paalanen]

On Thu,  7 Apr 2016 16:44:19 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> Activity for desktop-shell simply follows keyboard focus.  Only a single
> surface can be active at a time.
> 
> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> ---
>  desktop-shell/shell.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
> index 6e49076..48e4e30 100644
> --- a/desktop-shell/shell.c
> +++ b/desktop-shell/shell.c
> @@ -5065,6 +5065,8 @@ activate(struct desktop_shell *shell, struct weston_surface *es,
>  
>  	old_es = state->keyboard_focus;
>  	focus_state_set_focus(state, es);
> +	if (old_es != NULL)
> +		weston_surface_deactivate(old_es);
>  
>  	if (shsurf->state.fullscreen && configure)
>  		shell_configure_fullscreen(shsurf);

Hi,

seeing this, patch 2 should only add the new stuff and not remove
weston_surface_activate() until all shells are converted, and then each
shell should have its own patch converting it to the new thing.

This comment applies also to patches 5 and 6.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160526/91043672/attachment.sig>