[PATCH] weston-launch: Handle invalid command line options

Otavio Salvador otavio.salvador at ossystems.com.br
Mon May 16 19:03:03 UTC 2016

On Mon, May 16, 2016 at 3:43 PM, Yong Bakos <junk at humanoriented.com> wrote:
> On May 7, 2016, at 5:57 AM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>> From: Tom Hochstein <tom.hochstein at nxp.com>
>> Exit the program if an unrecognized command line option is found.
>> Signed-off-by; Tom Hochstein <tom.hochstein at nxp.com>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> Simple enough of a review, and I did test this. But the question is
> whether we want weston-launch to ignore invalid options or to quit in the
> event of their presence. I'm not experienced enough to judge, so others
> will have to chime in. So fwiw,
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Tested-by: Yong Bakos <ybakos at humanoriented.com>

I believe it ought to fail so we know we are giving it invalid
arguments otherwise it is very hard to identify why it is not behaving
as expected. We had this problem when implementing the XWayland
handling in OpenEmbedded.

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

More information about the wayland-devel mailing list