[PATCH weston 2/3] ivi-shell: describe members of type wl_list

[Pekka Paalanen]

On Fri, 1 Jul 2016 09:34:50 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> I wrote comments on which list they are used with
> 
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
>  ivi-shell/ivi-layout-private.h    |   16 ++++++++--------
>  ivi-shell/ivi-layout-transition.c |    2 +-
>  ivi-shell/ivi-layout.c            |    6 +++---
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/ivi-shell/ivi-layout-private.h b/ivi-shell/ivi-layout-private.h
> index c1b52f1..f7b2de9 100644
> --- a/ivi-shell/ivi-layout-private.h
> +++ b/ivi-shell/ivi-layout-private.h
> @@ -43,7 +43,7 @@ struct ivi_layout_view {
>  };
>  
>  struct ivi_layout_surface {
> -	struct wl_list link;
> +	struct wl_list link;	/* ivi_layout::surface_list */
>  	struct wl_signal property_changed;
>  	int32_t update_count;
>  	uint32_t id_surface;
> @@ -61,7 +61,7 @@ struct ivi_layout_surface {
>  };
>  
>  struct ivi_layout_layer {
> -	struct wl_list link;
> +	struct wl_list link;	/* ivi_layout::surface_list */

Hi,

I fixed this one to say "layer_list" instead.

>  	struct wl_signal property_changed;
>  	uint32_t id_layer;
>  
> @@ -73,13 +73,13 @@ struct ivi_layout_layer {
>  	struct {
>  		struct ivi_layout_layer_properties prop;
>  		struct wl_list view_list;	/* ivi_layout_view::pending_link */
> -		struct wl_list link;
> +		struct wl_list link;	/* ivi_layout_screen::pending.layer_list */
>  	} pending;
>  
>  	struct {
>  		int dirty;
>  		struct wl_list view_list;	/* ivi_layout_view::order_link */
> -		struct wl_list link;
> +		struct wl_list link;	/* ivi_layout_screen::order.layer_list */
>  	} order;
>  
>  	int32_t ref_count;
> @@ -88,9 +88,9 @@ struct ivi_layout_layer {
>  struct ivi_layout {
>  	struct weston_compositor *compositor;
>  
> -	struct wl_list surface_list;
> -	struct wl_list layer_list;
> -	struct wl_list screen_list;
> +	struct wl_list surface_list;	/* ivi_layout_surface::link */
> +	struct wl_list layer_list;	/* ivi_layout_layer::link */
> +	struct wl_list screen_list;	/* ivi_layout_screen::link */
>  	struct wl_list view_list;	/* ivi_layout_view::link */
>  
>  	struct {
> @@ -107,7 +107,7 @@ struct ivi_layout {
>  	struct weston_layer layout_layer;
>  
>  	struct ivi_layout_transition_set *transitions;
> -	struct wl_list pending_transition_list;
> +	struct wl_list pending_transition_list;	/* transition_node::link */
>  };
>  
>  struct ivi_layout *get_instance(void);
> diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c
> index 04b62a5..989ba71 100644
> --- a/ivi-shell/ivi-layout-transition.c
> +++ b/ivi-shell/ivi-layout-transition.c
> @@ -59,7 +59,7 @@ struct ivi_layout_transition {
>  
>  struct transition_node {
>  	struct ivi_layout_transition *transition;
> -	struct wl_list link;
> +	struct wl_list link;	/* ivi_layout::pending_transition_list */

I added a note about ivi_layout_transition_set::transition_list to this.

>  };
>  
>  static void layout_transition_destroy(struct ivi_layout_transition *transition);
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index f8533f9..4e56ace 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -74,18 +74,18 @@
>  struct ivi_layout;
>  
>  struct ivi_layout_screen {
> -	struct wl_list link;
> +	struct wl_list link;	/* ivi_layout::screen_list */
>  
>  	struct ivi_layout *layout;
>  	struct weston_output *output;
>  
>  	struct {
> -		struct wl_list layer_list;
> +		struct wl_list layer_list;	/* ivi_layout_layer::pending.link */
>  	} pending;
>  
>  	struct {
>  		int dirty;
> -		struct wl_list layer_list;
> +		struct wl_list layer_list;	/* ivi_layout_layer::order.link */
>  	} order;
>  };
>  

Both patches pushed:
   967b6bc..7da3823  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20161109/668ce99a/attachment.sig>