[PATCH wayland v2 3/3] tests: add scanner tests

Pekka Paalanen pekka.paalanen at collabora.co.uk
Wed Nov 16 11:53:05 UTC 2016

On Wed, 16 Nov 2016 13:38:17 +0200
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Add tests that ensure that wayland-scanner output for a given input does
> not change unexpectedly. This makes it very easy to review
> wayland-scanner patches.
> Before, when patches were proposed for wayland-scanner, I had to
> build wayland without the patches, save the generated files into a
> temporary directory, apply the patches, build again, and diff the old
> vs. new generated file.
> No more. Now whenever someone makes intentional changes to
> wayland-scanner's output, he will also have to patch the example output
> files to match. That means that reviewers see the diff of the generated
> files straight from the patch itself. Verifying the diff is true is as
> easy as 'make check'.
> The tests use separate example XML files instead of wayland.xml
> directly, so that wayland.xml can be updated without fixing scanner
> tests, avoiding the churn.
> example.xml starts as a copy of wayland.xml. If wayland.xml starts using
> new wayland-scanner features, they should be copied into example.xml
> again to be covered by the tests.
> This patch relies on the previous patch to actually add all the data
> files for input and reference output.
> The scanner output is fed through sed to remove parts that are allowed
> to vary: the scanner version string.
> v2: no need for scanner-test.sh to depend on the test data
> Task: https://phabricator.freedesktop.org/T3313
> Cc: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
> Cc: Yong Bakos <ybakos at humanoriented.com>
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  .gitignore            |  1 +
>  Makefile.am           | 29 ++++++++++++++++++++++++++++-
>  tests/scanner-test.sh | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 80 insertions(+), 1 deletion(-)
>  create mode 100755 tests/scanner-test.sh

I also force-pushed
with the new revision, plus the new patch sent separately to use
noinst_PROGRAMS instead of check_PROGRAMS.


More information about the wayland-devel mailing list