[PATCH weston] clients: Fix weston-scaler source-only mode to use integer width and height

Daniel Stone daniel at fooishbar.org
Wed Nov 16 14:49:24 UTC 2016


On 30 September 2016 at 17:13, Derek Foreman <derekf at osg.samsung.com> wrote:
> If only the source of a viewport is set, the width and height must
> be integer or the protocol mandates that the compositor generate an
> error.  This is because using only the source is a crop, and the
> width and height become the surface size - all surface sizes must
> be integer.
> Weston was fixed to generate this error in bb32ccc0, however the
> test app continued to use fractional co-ordinates when run as
> weston-scaler -s  (which only sets the viewport source)
> This leaves fractional width/height for the other cases, but uses
> integer for the crop-only mode.  The descriptions in the help text
> are still accurate with this change, but weston-scaler -s no longer
> exits with an error.
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>

Pushed with review, thanks. I'd like to just subsume the cursor-plane
one into the general plane_state rework anyway, if that's OK with you?

To ssh://git.freedesktop.org/git/wayland/weston
   be8a6d3..df84dbe  push -> master


More information about the wayland-devel mailing list