[PATCH weston] xwayland: Create the drag-and-drop window in weston_wm_dnd_init

Daniel Stone daniel at fooishbar.org
Wed Nov 16 15:32:11 UTC 2016


On 24 May 2016 at 19:34, Derek Foreman <derekf at osg.samsung.com> wrote:
> On 22/02/16 12:42 PM, Carlos Garnacho wrote:
>> Just to keep it hidden so far... A lot of the plumbing necessary to
>> handle x11->wayland drag and drop is missing, and the current
>> partial handling gets in the middle for X11 drag-and-drop itself
>> to work.
>> The approach is well directed, but needs some further work, till
>> then, just keep our fake drag-and-drop target hidden. This allows
>> drag-and-drop to work between X11 clients in Xwayland, and avoids
>> a crash with (currently unhandled) wl_resource-less data sources.
>> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94218
> This seems to be a pretty important stop-gap patch neglected for quite
> some time. :(

Yikes, quite some time indeed.

> It looks superficially ok to me, but I'm really not equipped to provide
> proper review, I'll happily:
> Acked-by: Derek Foreman <derekf at osg.samsung.com>
> because I trust Carlos to follow up :)

Carlos, do you still think this is good?

> And maybe if we can get linkmauve to test, as he was the author of the
> bug ticket, we can land it?

Emmanuel, can you please test?


More information about the wayland-devel mailing list