[PATCH weston] editor: Fix g_type_init() call

Daniel Stone daniel at fooishbar.org
Wed Nov 16 15:40:48 UTC 2016


Hi Quentin,

On 23 June 2016 at 20:06, Quentin Glidic
<sardemff7+wayland at sardemff7.net> wrote:
> From: Quentin Glidic <sardemff7+git at sardemff7.net>
>
> HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong.
> g_type_init() was never called, which is fine since GLib 2.36 anyway.
> It is better not to have a wrong usage of HAVE_PANGO here.
>
> Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> ---
>
> We can also just drop g_type_init() altogether if the GLib version sounds
> correct. FTR, Debian stable (Jessie) has GLib 2.42 and oldstable (Wheezy)
> has GLib 2.33.

Yeah, my vote is to just bin it.

Cheers,
Daniel


More information about the wayland-devel mailing list