[PATCH wayland] Makefile: build also test programs during a normal build

Daniel Stone daniel at fooishbar.org
Wed Nov 16 16:30:59 UTC 2016


Hi Jan,

On 16 November 2016 at 16:19, Jan Engelhardt <jengelh at inai.de> wrote:
> On Wednesday 2016-11-16 17:16, Daniel Stone wrote:
>>>  noinst_PROGRAMS =                              \
>>> +       $(built_test_programs)                  \
>>> +       exec-fd-leak-checker                    \
>>>         fixed-benchmark
>>>
>>>  check_LTLIBRARIES = libtest-runner.la
>>
>>Doesn't this have to be (or at least, shouldn't: I can imagine
>>autotools making it a non-issue, but it is at least unclean)
>>noinst_LTLIBRARIES instead? With that:
>
> noinst_LTLIBRARIES will never build shared libraries. You can of
> course do that, but it has the usual implications.

Thanks for the super-quick response. This is only used for the built
tests, so I don't really see much value in having a shared library;
any space savings are probably obliterated by all the libtool files
anyway.

I tried both quickly and they both seem to work, given that automake
generates the rules and dependencies correctly; it's just that it
looks/feels quite weird.

Cheers,
Daniel


More information about the wayland-devel mailing list