[wayland-protocols] linux-dmabuf: advertise format modifiers with modifier event
Yong Bakos
junk at humanoriented.com
Thu Nov 17 15:29:25 UTC 2016
Hi Varad,
> On Nov 17, 2016, at 3:55 AM, Varad Gautam <varadgautam at gmail.com> wrote:
>
> From: Varad Gautam <varad.gautam at collabora.com>
>
> advertise the supported fourcc format modifiers along with supported
> formats to the client.
>
> bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> versions to 3.
>
> Signed-off-by: Varad Gautam <varad.gautam at collabora.com>
Just one minor nit that clarifies the request, below.
> ---
> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 24 +++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> index a0aa42e..b60483b 100644
> --- a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> +++ b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> @@ -26,7 +26,7 @@
> THIS SOFTWARE.
> </copyright>
>
> - <interface name="zwp_linux_dmabuf_v1" version="2">
> + <interface name="zwp_linux_dmabuf_v1" version="3">
> <description summary="factory for creating dmabuf-based wl_buffers">
> Following the interfaces from:
> https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt
> @@ -34,7 +34,8 @@
>
> This interface offers ways to create generic dmabuf-based
> wl_buffers. Immediately after a client binds to this interface,
> - the set of supported formats is sent with 'format' events.
> + the set of supported formats and format modifiers is sent with
> + 'format' and 'modifier' events.
>
> The following are required from clients:
>
> @@ -110,9 +111,26 @@
> </description>
> <arg name="format" type="uint" summary="DRM_FORMAT code"/>
> </event>
> +
> + <event name="modifier" since="3">
> + <description summary="supported buffer format modifier">
> + This event advertises the formats that the server supports, along with
> + the modifiers supported for each format. All the supported modifiers for
> + all the supported formats are advertised once when the client binds to
> + this interface. A roundtrip after binding guarantees that the client
> + has received all supported format-modifier pairs.
> +
> + For the definition of the format and modifier codes, see create request.
see the create request.
or
see the zwp_linux_buffer_params_v1::create request.
Since this event description, in the zwp_linux_dmabuf_v1 interface, refers to
the `create` in a different interface, the prefix helps clarify this. Especially
since zwp_linux_dmabuf_v1 has a `create_params` request.
yong
> + </description>
> + <arg name="format" type="uint" summary="DRM_FORMAT code"/>
> + <arg name="modifier_hi" type="uint"
> + summary="high 32 bits of layout modifier"/>
> + <arg name="modifier_lo" type="uint"
> + summary="low 32 bits of layout modifier"/>
> + </event>
> </interface>
>
> - <interface name="zwp_linux_buffer_params_v1" version="2">
> + <interface name="zwp_linux_buffer_params_v1" version="3">
> <description summary="parameters for creating a dmabuf-based wl_buffer">
> This temporary object is a collection of dmabufs and other
> parameters that together form a single logical buffer. The temporary
> --
> 2.6.2
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
More information about the wayland-devel
mailing list