[PATCH] xdg-shell: clarify popup constrain's slide mechanism

[Yong Bakos]

Hi Mike,

> On Nov 16, 2016, at 7:23 AM, Mike Blumenkrantz <zmike at osg.samsung.com> wrote:
> 
> some restrictions must be placed on this or else it becomes legal for
> the compositor to place popups in unexpected locations when sliding
> is allowed
> 
> Signed-off-by: Mike Blumenkrantz <zmike at osg.samsung.com>

Per your description of the problem, this protocol change seems to make
sense, and adds specificity to the constraining behavior. I can't think
of any drawbacks to adding this.

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

yong



> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index 6053e3c..30cdaeb 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -256,7 +256,8 @@
>       </entry>
>       <entry name="slide_x" value="1">
> 	<description summary="move along the x axis until unconstrained">
> -	  Slide the surface along the x axis until it is no longer constrained.
> +	  Slide the surface along the x axis within the toplevel surface until it
> +	  is no longer constrained.
> 
> 	  First try to slide towards the direction of the gravity on the x axis
> 	  until either the edge in the opposite direction of the gravity is
> @@ -271,7 +272,8 @@
>       </entry>
>       <entry name="slide_y" value="2">
> 	<description summary="move along the y axis until unconstrained">
> -	  Slide the surface along the y axis until it is no longer constrained.
> +	  Slide the surface along the y axis within the toplevel surface until it
> +	  is no longer constrained.
> 
> 	  First try to slide towards the direction of the gravity on the y axis
> 	  until either the edge in the opposite direction of the gravity is
> -- 
> 2.5.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel