[PATCH] wayland-client: Require base 10 for WAYLAND_SOCKET, explicitly

Daniel Stone daniel at fooishbar.org
Mon Nov 21 11:36:10 UTC 2016


On 9 July 2016 at 02:36, Yong Bakos <junk at humanoriented.com> wrote:
> On Jul 8, 2016, at 4:42 PM, Bryce Harrington <bryce at osg.samsung.com> wrote:
>> The third arg to strtol() specifies the base to assume for the number.
>> When 0 is passed, as is currently done in wayland-client.c, hexadecimal
>> and octal numbers are permitted and automatically detected and
>> converted.
>> I can find no indication that we would ever expect use of hexadecimal or
>> octal for socket fd's.  So be explicit about what base we're assuming
>> here and avoid any potential surprises.
>> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> I can think of no drawbacks to this.

Yeah, me neither. Thanks Bryce!

To ssh://git.freedesktop.org/git/wayland/wayland
   b05baa6..a2cbdef  master -> master


More information about the wayland-devel mailing list