[RFC wayland 0/1] tests: Test wl_argument_from_va_list

Daniel Stone daniel at fooishbar.org
Mon Nov 21 11:42:03 UTC 2016

Hi Yong,

On 13 November 2016 at 19:14, Yong Bakos <junk at humanoriented.com> wrote:
> My ongoing routine of documenting objects and checking for related test coverage
> has recently led me to notice that wl_argument_from_va_list does not have a
> specific test in connection-test.c. The 1/1 patch in this RFC describes a rough
> draft at the testing approach: using a wrapper function to generate a va_list
> for wl_argument_from_va_list, and checking the results.
> I have two questions regarding this RFC, and welcome any additional comments.
> 1) What message signatures should be tested, and how many?
> 2) I'd like to replace the procedural approach with an iterative one,
>    but I can't quite see how this will be possible. Any suggestions?

I don't think there's any real reason to go hugely overboard on this.
The only real thing it even does is demarshal the type names, so a
single check for each type - as well as making sure that multiple
arguments work, which you've done - is fine. Everything else should
already be exercised. So maybe a quick: '?iuf?sonah' in addition to
the two you've got, and that'll close it out.


More information about the wayland-devel mailing list