[PATCH weston v2 1/2] config-parser: add support for more color formats

Daniel Stone daniel at fooishbar.org
Mon Nov 21 17:00:18 UTC 2016


Hi Eric,

On 26 October 2016 at 23:53, Eric Engestrom <eric at engestrom.ch> wrote:
> Supported colour formats are:
> - (0x)(AA)RRGGBB
> - #RGB(A)
> - #RRGGBB(AA)

If I'm honest, I don't entirely see the value in these. Accepting
12345678 as well as 0x12345678 implies, to me at least, that the
former will be interpreted as decimal and the latter as hexadecimal.
Obviously it would be better if we'd only accepted 0x for hex in the
first place, but here we are. I'd still rather not increase the
confusion by accepting both at this point.

I similarly don't think the # adds that much value (people can figure
it out easily enough), and the half-precision variant is rare enough
that I'm not sure it's worth supporting.

So, exceedingly long lines notwithstanding, it's a nice enough patch,
but I'd rather just leave it be, suboptimal though the current
situation is. Thanks and sorry.

Cheers,
Daniel


More information about the wayland-devel mailing list