[PATCH wayland v2] util: Clarify documentation of wl_dispatcher_func_t

Daniel Stone daniel at fooishbar.org
Mon Nov 21 17:14:53 UTC 2016


Hi Yong,

On 21 November 2016 at 13:44, Yong Bakos <junk at humanoriented.com> wrote:
> - * A dispatcher takes five arguments:  The first is the dispatcher-specific
> - * implementation data associated with the target object.  The second is the
> - * object on which the callback is being invoked (either wl_proxy or
> - * wl_resource).  The third and fourth arguments are the opcode the wl_message
> - * structure corresponding to the callback being emitted.  The final argument
> - * is an array of arguments received from the other process via the wire
> - * protocol.
> + * A dispatcher takes five arguments: The first is the dispatcher-specific
> + * implementation associated with the target object. The second is the object
> + * upon which the callback is being invoked (either wl_proxy or wl_resource).
> + * The third and fourth arguments are the opcode and the wl_message
> + * corresponding to the callback. The final argument is an array of arguments
> + * received from the other process via the wire protocol.

I think removing the final word 'the dispatcher-specific
implementation data' is a loss of precision/accuracy. If you don't
mind reinstating that final word, I'll merge with my R-b.

Cheers,
Daniel


More information about the wayland-devel mailing list