[weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

Daniel Stone daniel at fooishbar.org
Mon Nov 21 17:49:57 UTC 2016


Hi Vincent,

On 7 October 2016 at 16:08, Vincent Abriou <vincent.abriou at st.com> wrote:
> @@ -72,6 +72,9 @@ install-libweston_moduleLTLIBRARIES install-moduleLTLIBRARIES: install-libLTLIBR
>  lib_LTLIBRARIES = libweston- at LIBWESTON_MAJOR@.la
>  libweston_ at LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON
>  libweston_ at LIBWESTON_MAJOR@_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS) $(LIBUNWIND_CFLAGS)
> +if ENABLE_DRM_COMPOSITOR
> +libweston_ at LIBWESTON_MAJOR@_la_CFLAGS += $(DRM_COMPOSITOR_CFLAGS)
> +endif
>  libweston_ at LIBWESTON_MAJOR@_la_LIBADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
>         $(DLOPEN_LIBS) -lm $(CLOCK_GETTIME_LIBS) \
>         $(LIBINPUT_BACKEND_LIBS) libshared.la

So, given that the set of formats is defined unconditionally in
gl-renderer, this would break compilation with --disable-drm-backend.
The options that come to mind are either: using wl_shm enums for these
formats, shipping a local copy of drm_fourcc.h, or mandating the DRM
backend for dmabuf. Of those, I'd prefer the first, I think.

I did merge your YUYV patch, though: thanks!

Cheers,
Daniel


More information about the wayland-devel mailing list