[RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

Daniel Stone daniel at fooishbar.org
Tue Nov 22 09:10:59 UTC 2016


On 21 November 2016 at 23:13, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> On Mon, Nov 21, 2016 at 12:42:36PM +0000, Daniel Stone wrote:
>> Concretely though, reusing BTN_* codes where possible would make it
>> easier for clients to transition between the two.
> I disagree here. The kernel only has BTN_STYLUS and BTN_STYLUS2, after that
> we overlap with DOUBLETAP range and later buttons that are completely
> different (e.g. BTN_GEAR_DOWN). I think this would only make it worse.
> This protocol is still unstable, every client needs updates once we mark it
> stable anyway, making the enums *values* mean something is counterproductive
> IMO.

Shrug, once in an enum they're totally arbitrary values (so which
BTN_* they overlap doesn't make a difference), and it does make it a
little harder to screw it up, as well as easier to stay compatible
between multiple versions. But, your call.


More information about the wayland-devel mailing list