[PATCH weston] compositor: allow using nested parent as a subsurface sibling

Daniel Stone daniel at fooishbar.org
Tue Nov 22 12:40:30 UTC 2016

Hi Arnaud,

On 8 June 2016 at 17:37, Arnaud Vrac <avrac at freebox.fr> wrote:
> The parent of a subsurface can be used as a sibling in the place_below
> and place_above calls. However this did not work when the parent is
> nested, so fix the sibling check and add a test to check this case.

It took a few reads over, but after that, and writing a few more tests
to validate things (which, disappointingly, passed on both old and new
Reviewed-by: Daniel Stone <daniels at collabora.com>

I've made one very minor change though, which is to change 'struct
wl_surface *parent' to 'struct wl_surface *grandchild' in the new
tests: after all, the surface we're creating will never be the parent
of anything, is the child of one thing, and crucially for the test, is
the child of something which already has a child. Hope that's OK.

Thanks for the patch!
To ssh://git.freedesktop.org/git/wayland/weston
   11f8fcb..b8c16c9  upstream -> master


More information about the wayland-devel mailing list