[wayland-protocols v3] linux-dmabuf: advertise format modifiers with modifier event

[Daniel Vetter]

On Wed, Nov 23, 2016 at 02:39:01PM +0100, Daniel Vetter wrote:
> On Mon, Nov 21, 2016 at 07:59:51PM +0000, Daniel Stone wrote:
> > Hi Varad,
> > 
> > On 21 November 2016 at 10:17, Varad Gautam <varadgautam at gmail.com> wrote:
> > > advertise the supported fourcc format modifiers along with supported
> > > formats to the client.
> > >
> > > bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> > > versions to 3.
> > 
> > Reviewed-by: Daniel Stone <daniels at collabora.com>
> > 
> > I'll wait a little while with this series to see if more review pops
> > up, and then merge it if not.
> 
> Well in upstream kernel we just nerved modifier[1-3] and require they
> match modifier[0]. Oops. Do we need to take adjustments in wayland now
> too? At elast enforcing everywhere that modifiers match is probably a good
> thing, and maybe even adjusting proto extensions and internal storage to
> only carry one?

Reply to the wrong patch. Proto looks good, but the weston implementation
should probably gain some checks to make sure modifier[1-3] == 0 or
modifier[0], and using modifier[0] for the other planes in the egl interop
stuff. Might also want to just throw away the additional modifiers from
internal structs.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch