[PATCH weston 6/6] libweston-desktop/xwayland: add is_mapped handling for XWAYLAND

Daniel Stone daniel at fooishbar.org
Thu Nov 24 12:38:55 UTC 2016

Hi Pekka,

On 24 November 2016 at 11:40, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> The xwayland window type XWAYLAND is not handled by the shell at all,
> instead libweston-desktop maps such surfaces itself. However, it forgot
> to set weston_surface::is_mapped and weston_view::is_mapped.
> weston_surface::is_mapped affects the behaviour of weston_view_unmap()
> and weston_surface_attach().
> weston_view::is_mapped affects the behaviour of weston_view_unmap() and
> weston_view_destroy().
> When manually mapping a window of type XWAYLAND, mark both the view and
> surface as mapped. This follows the expections in libweston, even though
> the meaning of is_mapped is not clearly defined for either surface or
> view.
> Also, when the XWAYLAND window is manually unmapped, unmap the
> weston_surface. This updates weston_surface::is_mapped to reflect the
> state. However, as a side-effect it will also unmap all sibling views,
> should any exist.

Your rationale is convincing, but I don't know the code well enough;
I'll wait for Giulio on this one, and in the meantime give it:
Acked-by: Daniel Stone <daniels at collabora.com>

The rest though (with the comment on 3/6 taken care of) is:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Might be worth a reference to
https://phabricator.freedesktop.org/T7622 in there as well.


More information about the wayland-devel mailing list