[PATCH weston v2] compositor-wayland: Fix a use after free
dima at gmail.com
Mon Nov 28 21:32:59 UTC 2016
Oh, good catch; just reviewed it. Thanks!
On Mon, Nov 28, 2016 at 10:20 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi Dima,
> On 24 November 2016 at 13:13, Dima Ryazanov <dima at gmail.com> wrote:
> > When a window is being closed, the frame_done callback often runs after
> > the output is already destroyed, i.e:
> > wayland_output_start_repaint_loop
> > input_handle_button
> > wayland_output_destroy
> > frame_done
> > To fix this, destroy the callback before destroying the output.
> > (Also, fix the type of output in frame_done: it's passed in
> > a wayland_output, not a weston_output.)
> I accidentally pushed this, when I meant to push the gl-renderer patch
> instead. Turns out this breaks Pixman; I've sent a follow-up patch
> which fixes this. Can you please review it when you can?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the wayland-devel