[PATCH weston] gl-renderer: Add a #define to obtain the prototypes from the gl2 header.

[Pekka Paalanen]

On Thu, 1 Sep 2016 15:32:08 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 1 September 2016 at 15:12, Emmanuel Gil Peyrot
> <emmanuel.peyrot at collabora.com> wrote:
> > This prevents a segfault when running on Mesa master, due to the GLES2
> > symbols not being declared with the correct prototype (or at all).
> >
> > Signed-off-by: Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com>
> > ---
> >  libweston/gl-renderer.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
> > index 031576b..3979c3a 100644
> > --- a/libweston/gl-renderer.c
> > +++ b/libweston/gl-renderer.c
> > @@ -26,6 +26,7 @@
> >
> >  #include "config.h"
> >
> > +#define GL_GLEXT_PROTOTYPES  
> General rule of thumb is that:
>  - Extension symbols are fetched via the {wgl,glX,egl}GetProcAddress APIs
>  - By defining *_PROTOTYPES you explicitly acknowledge that your
> program is _not_ portable.

And for that reason, NAK indeed.

> Yet again, it could be that there's something busted in mesa which
> will require this, in which case you want a big warning/message and a
> friendly poke to mesa-dev/bugzilla :-)

Yeah, maybe explain in more detail what issue you actually have. I
can't imagine how this patch would fix anything.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160902/ec980633/attachment-0001.sig>