[PATCH libinput] tools: prefix debug output with '.' on device changes
Peter Hutterer
peter.hutterer at who-t.net
Thu Sep 15 22:28:27 UTC 2016
On Thu, Sep 15, 2016 at 02:02:03PM +0100, Eric Engestrom wrote:
> On Thu, Sep 15, 2016 at 07:55:54AM +1000, Peter Hutterer wrote:
> > On Wed, Sep 14, 2016 at 05:48:26PM +0100, Eric Engestrom wrote:
> > > On Thu, Sep 08, 2016 at 03:55:47PM +1000, Peter Hutterer wrote:
> > > > diff --git a/tools/event-debug.c b/tools/event-debug.c
> > > > index 67432b7..0e95611 100644
> > > > --- a/tools/event-debug.c
> > > > +++ b/tools/event-debug.c
> > > > @@ -49,8 +49,11 @@ static unsigned int stop = 0;
> > > > static void
> > > > print_event_header(struct libinput_event *ev)
> > > > {
> > > > + /* use for pointer value only, do not dereference */
> > > > + static struct libinput_device *last_device = NULL;
> > >
> > > I would make that a void* to make it clear that it's not meant to be
> > > dereferenced.
> >
> > I've already pushed this patch for 1.5 but I've changed this in a follow-up
> > patch now. Thanks.
>
> $DAYJOB's email infrastructure could be better... and because of that
> I only read your reply just now... I guess you can discard my patch :)
I hadn't pushed the other one yet, so it was easy to replace it with yours.
Might as well get more names into the git log ;)
Cheers,
Peter
More information about the wayland-devel
mailing list