[PATCH wayland-protocols] input-method: Cleanup some grammar

Yong Bakos junk at humanoriented.com
Sat Sep 17 17:07:15 UTC 2016


On Sep 16, 2016, at 9:37 PM, Bryce Harrington <bryce at osg.samsung.com> wrote:
> 
> Fix which vs. that, and rephrase a few descriptions to be clearer.
> 
> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

yong


> ---
> unstable/input-method/input-method-unstable-v1.xml | 25 +++++++++++-----------
> 1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/unstable/input-method/input-method-unstable-v1.xml b/unstable/input-method/input-method-unstable-v1.xml
> index e9d93ba..e454a55 100644
> --- a/unstable/input-method/input-method-unstable-v1.xml
> +++ b/unstable/input-method/input-method-unstable-v1.xml
> @@ -39,7 +39,7 @@
>       commit_state request and are used by the input method to indicate
>       the known text input state in events like preedit_string, commit_string,
>       and keysym. The text input can then ignore events from the input method
> -      which are based on an outdated state (for example after a reset).
> +      that are based on an outdated state (for example after a reset).
> 
>       Warning! The protocol described in this file is experimental and
>       backward incompatible changes may be made. Backward compatible changes
> @@ -55,11 +55,11 @@
> 
>     <request name="commit_string">
>       <description summary="commit string">
> -	Send the commit string text for insertion to the application.
> +	Send the commit string text to the application for insertion.
> 
> -	The text to commit could be either just a single character after a key
> -	press or the result of some composing (pre-edit). It could be also an
> -	empty text when some text should be removed (see
> +	The text could be a single character corresponding to an ordinary key
> +	press, one or more characters forming the result of a compose action
> +	(pre-edit), or no characters such as when text should be removed (see
> 	delete_surrounding_text) or when the input cursor should be moved (see
> 	cursor_position).
> 
> @@ -86,10 +86,11 @@
> 
>     <request name="preedit_styling">
>       <description summary="pre-edit styling">
> -	Set the styling information on composing text. The style is applied for
> -	length in bytes from index relative to the beginning of
> -	the composing text (as byte offset). Multiple styles can
> -	be applied to a composing text.
> +	Set the styling information on a section of the composing text
> +	offset index bytes from the beginning and ending at length
> +	bytes.
> +
> +	Multiple styles can be applied to a composing text.
> 
> 	This request should be sent before sending a preedit_string request.
>       </description>
> @@ -100,7 +101,7 @@
> 
>     <request name="preedit_cursor">
>       <description summary="pre-edit cursor">
> -	Set the cursor position inside the composing text (as byte offset)
> +	Set the cursor position inside the composing text (as a byte offset)
> 	relative to the start of the composing text.
> 
> 	When index is negative no cursor should be displayed.
> @@ -245,13 +246,13 @@
>       An input method object is responsible for composing text in response to
>       input from hardware or virtual keyboards. There is one input method
>       object per seat. On activate there is a new input method context object
> -      created which allows the input method to communicate with the text input.
> +      created that allows the input method to communicate with the text input.
>     </description>
> 
>     <event name="activate">
>       <description summary="activate event">
> 	A text input was activated. Creates an input method context object
> -	which allows communication with the text input.
> +	that allows communication with the text input.
>       </description>
>       <arg name="id" type="new_id" interface="zwp_input_method_context_v1"/>
>     </event>
> -- 
> 1.9.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list