[PATCH wayland 3/4] tests: Test wl_array_release

[Pekka Paalanen]

On Fri, 16 Sep 2016 15:37:38 -0700
Yong Bakos <junk at humanoriented.com> wrote:

> From: Yong Bakos <ybakos at humanoriented.com>
> 
> array-test.c did not cover wl_array_release, so add one test that specifically
> tests this method.
> 
> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> ---
>  tests/array-test.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tests/array-test.c b/tests/array-test.c
> index fe53240..a5856fd 100644
> --- a/tests/array-test.c
> +++ b/tests/array-test.c
> @@ -45,6 +45,16 @@ TEST(array_init)
>  	}
>  }
>  
> +TEST(array_release)
> +{
> +	struct wl_array array;
> +	wl_array_init(&array);

Hi

> +	array.data = calloc(1, sizeof(int));

This is something one should never do, it is asking for problems. Why
don't you use wl_array_add()?


Thanks,
pq

> +	assert(array.data != NULL);
> +	wl_array_release(&array);
> +	assert(array.data == NULL);
> +}
> +
>  TEST(array_add)
>  {
>  	struct mydata {

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160920/6c2840c5/attachment.sig>