[PATCH weston v10 15/61] compositor-drm: Clean up page_flip_pending path

Daniel Stone daniel at fooishbar.org
Fri Apr 7 14:03:33 UTC 2017

Hi Pekka,

On 7 April 2017 at 14:55, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Btw. I'll get rid of the phab tags and dual-SoB when I push. Unless
> someone else pushes first. :-)

Thanks! I left them there for later patches since there was still the
possibility that someone might review there, but eh, might as well
just keep the whole thing on the list really.

> The reason we cannot just remove page_flip_pending completely in favour
> of the other variables like fb_last is that then we would miss the
> initial flip from nothing to the very first FB, right?

No, we need it so I can scatter more asserts through. ;)

More seriously, it's used so we can defer destroy/disable until after
a pageflip has completed.


More information about the wayland-devel mailing list