[PATCH weston 01/15] libweston: improve weston_output_disable() comments

Pekka Paalanen ppaalanen at gmail.com
Tue Apr 11 12:52:41 UTC 2017


On Tue, 4 Apr 2017 21:22:55 +0200
Armin Krezović <krezovic.armin at gmail.com> wrote:

> On 04.04.2017 12:58, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Reorder some paragraphs to be more logically ordered. Rewrite the
> > description of the backend-specific disable function to explain the
> > semantics instead of the mechanics. Remove the paragraph about
> > pending_output_list as unnecessary details.
> > 
> > Add a big fat comment on why we call output->disable() always instead of
> > only for actually enabled outputs.
> >   
> 
> Might also note that it's only relevant to drm-backend at the moment.

Hi,

I had hoped it was kind of obvious, talking about turning outputs off.
It could apply to the Wayland backend with fullscreen shell, too.

> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>  
> 
> Nevertheless,
> 
> Reviewed-by: Armin Krezović <krezovic.armin at gmail.com>

Pushed this one:
   08d4edf..c65df64  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170411/4a67367f/attachment.sig>


More information about the wayland-devel mailing list