[PATCH weston v2] compositor-drm: Fix disabling cursor plane

Derek Foreman derekf at osg.samsung.com
Thu Apr 13 20:42:16 UTC 2017

On 13/04/17 03:23 PM, Daniel Stone wrote:
> Hi Derek,
> On 13 April 2017 at 21:11, Derek Foreman <derekf at osg.samsung.com> wrote:
>> commit a7cba1d4cd4c9013c3ac6cb074fcb7842fb39283 changed the way
>> the cursor plane is setup.  Previously it was pre-emptively set
>> disabled for the next frame, and that would be changed at next
>> frame time if the cursor plane was to be used.  It was changed
>> to be disabled at plane assignment time.
>> We disable the use of planes entirely by setting disable_planes to
>> a non-zero value, which bypasses all calls to assign_planes - so
>> if the plane was set-up in the previous frame it will retain its
>> state post-disable.
>> This leads to desktop zoom leaving the cursor plane in place when
>> it sets disable_planes.
>> This patch clears any stale cursor plane state from the redraw
>> handler if disable_planes is set so drm_output_set_cursor()
>> will do the right thing.
> Good catch and equally good fix, thanks! Please feel free to land directly with:
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com>

Thanks - pushed.

> Cheers,
> Daniel

More information about the wayland-devel mailing list