[PATCH weston 1/2] text-backend: Allow client hiding of input panel

[Joshua Watt]

On Wed, 2017-07-19 at 17:48 +0200, Silvan Jegen wrote:
> On Wed, Jul 19, 2017 at 3:49 PM, Joshua Watt <jpewhacker at gmail.com>
> wrote:
> > On Sun, 2017-07-09 at 21:26 +0200, Silvan Jegen wrote:
> > > Hi Joshua
> > > 
> > > On Wed, Jul 05, 2017 at 08:58:51AM -0500, Joshua Watt wrote:
> > > > On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote:
> > > > > Previously, the hide_input_panel and show_input_panel
> > > > > messages
> > > > > for
> > > > > the text
> > > > > input protocol were limited to specific cases, such as
> > > > > showing
> > > > > the
> > > > > panel on
> > > > > activation, or making the panel visible after activation.
> > > > > Now,
> > > > > clients are
> > > > > allowed to toggle the panel visiblity at will as long as they
> > > > > are
> > > > > the
> > > > > currently
> > > > > active client
> > > > > 
> > > > > Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
> > > > > ---
> > > > >  compositor/text-backend.c | 22 ++++++++++++----------
> > > > >  1 file changed, 12 insertions(+), 10 deletions(-)
> > > > > 
> > > > 
> > > > Ping?
> > > 
> > > I have tested your two patches locally and can confirm that they
> > > compile
> > > and run.
> > > 
> > > Letting the user toggle the visibility of the input panel with a
> > > click
> > > (in the --click-to-show case) seems like a good change to me. I
> > > doubt
> > > that there are any strong opinions on this though...
> > 
> > Any further updates on this?
> 
> We will have to wait for somebody with commit rights to chime in :)
> 
> I would be really interested in the next version of the
> text*protocols
> as well but development of them seems to have stalled for now,
> unfortunately. There was a new version forthcoming that is pending
> some changes. They have been pending for more than a year now though.

Any other comments?

> 
> 
> Cheers,
> 
> Silvan