[PATCH weston] compositor-fbdev: fix start-up assertion

[Pekka Paalanen]

On Tue, 15 Aug 2017 21:28:42 +0200
Armin Krezović <krezovic.armin at gmail.com> wrote:

> On 15.08.2017 09:43, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Fixes the failure to start with fbdev-backend:
> > 
> > weston: /home/pq/git/weston/libweston/compositor.c:4733: weston_compositor_add_pending_output: Assertion `output->disable' failed.
> > 
> > The disable hook was completely unimplemented, and the regression was
> > caused by e952a01c3b42c7c870091e71488e9469bd897153
> > "libweston: move asserts to add_pending_output()".
> > It used to work because Weston never tried to explicitly disable the
> > fbdev output, but now it is hitting the assert.
> > 
> > Fix it by tentatively implementing a disable hook. It has not been
> > tested to work for explicit disabling, but it does solve the regression.
> > 
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102208
> > Cc: bluescreen_avenger at verizon.net
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>  
> 
> Hi,
> 
> Looks reasonable:
> 
> Reviewed-by: Armin Krezović <krezovic.armin at gmail.com>
> 

Awesome, thank you both. Pushed:
   167bbb6d..acd71fb0  master -> master


This patch would be good for the 3.0 stable branch as well, but I'm not
sure how we handle that.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170816/044b6665/attachment.sig>