[PATCH weston 8/8] compositor: protocol logger

[Pekka Paalanen]

On Thu, 24 Aug 2017 16:16:22 +0200
Maniraj Devadoss <external.mdevadoss at de.adit-jv.com> wrote:

> This is better than running Weston with WAYLAND_DEBUG=server:
> - It is enabled on demand, no unnecessary flooding and no need to
>   restart the compositor if debug was enabled.
> - It prints client pointers so that messages with different clients can
>   be seen apart.
> 
> Signed-off-by: Pekka Paalanen <pq at iki.fi>
> 
> parse and print message arguments in protocol_log_fn
> 
> Signed-off-by: Maniraj Devadoss <external.mdevadoss at de.adit-jv.com>
> ---
>  compositor/main.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 125 insertions(+), 2 deletions(-)

Hi,

very good, the added code looks correct to me.

Inside switch blocks you have indented with spaces when we use tabs.
That should be fixed.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170830/d6253214/attachment-0001.sig>