[PATCH wayland] protocol: Add deprecation note about wl_shell

Pekka Paalanen ppaalanen at gmail.com
Mon Dec 4 08:16:10 UTC 2017

On Sat,  2 Dec 2017 10:57:45 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> Now that xdg_shell is stable and much better defined than wl_shell we
> can finally deprecate wl_shell and guide users towards xdg_shell
> instead.
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---


Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

> Eventually we can consider adding deprecation attributes the
> <interface> XML nodes that'll turn into compiler warnings, but this is
> at least a start moving away from wl_shell. I imagine the wl_shell users
> today (SDL, GLFW at least) to hopefully migrate soon, but keep the
> wl_shell as a fallback for the time being while compositors add support
> for xdg_shell. So we probably don't want to add compiler warnings for
> them just yet.

I would imagine compositors wanting to keep the support for a long
time, so maybe the warnings would be just in the client header?

OTOH, ISTR problems with having deprecation warnings in
system-installed headers, compilers ignoring them...


>  protocol/wayland.xml | 3 +++
>  1 file changed, 3 insertions(+)
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index aabc7ae..77d991e 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -976,6 +976,9 @@
>        It allows clients to associate a wl_shell_surface with
>        a basic surface.
> +
> +      Note! This protocol is deprecated and not intended for production use.
> +      For desktop-style user interfaces, use xdg_shell.
>      </description>
>      <enum name="error">

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171204/a5870c0c/attachment-0001.sig>

More information about the wayland-devel mailing list