[PATCH wayland-protocols 2/3] tests: Add compile tests

Daniel Stone daniel at fooishbar.org
Mon Dec 4 22:49:09 UTC 2017


Hi,
Meant 'patch' rather than 'series' when offering my R-b to the other
patch. Oops.

On 11 October 2017 at 10:00, Jonas Ã…dahl <jadahl at gmail.com> wrote:
> +  # Check that header can be included by a pedantic C99 compiler
> +  test_name = 'test-build-pedantic- at 0@'.format(protocol.underscorify())
> +  test_name_source = '@0 at .c'.format(test_name)
> +  test_source = custom_target(test_name_source,
> +                              input: 'build-pedantic.c.in',
> +                              output: test_name_source,
> +                              command: replace_command)
> +  pedantic_test_executable = executable(test_name,
> +                                        [ test_source,
> +                                          client_header,
> +                                          server_header,
> +                                          code ],
> +                                        dependencies: libwayland,
> +                                        c_args: [ '-std=c99',
> +                                                  '-pedantic',
> +                                                  '-Wall',
> +                                                  '-Werror' ],
> +                                        install: false)
> +  test(test_name, pedantic_test_executable)
> +
> +  # Check that the header
> +  if not protocol.contains('xdg-foreign-unstable-v1')

The comment ends abruptly, the xdg_foreign exclusion is a massive
non-sequitur, and also test_configuration can be deleted. With that,
this is also:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list