[PATCH wayland v2 0/8] Import wayland-egl frontend library

Arnaud Vrac rawoul at gmail.com
Tue Dec 12 20:48:46 UTC 2017


Hi Emil,

On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi all,
>
> Here is a retake of the RFC as originally seen here [1].
>
> In summary - we want the user facing library to live in Wayland with
> vendors providing a backend/plugin.  Otherwise we'll get file conflicts
> as library can come from different vendors.
>
> Changes since v2 include:
>  - pushed multiple cleanups to Mesa and rebased the series on top
>  - cut down the fluff in the 1/9 commit message.
>  - use 17.4.0 version to avoid breakage of existing apps
>  - pass the DSO name (used in the symbol test) via the build system
>  - use local WL_EXPORT macro
>
>
> I've kept the import and build integration, since:
>  - the former is mechanical, while the latter involves some brain cells
>  - couple of changes were needed before building the imported code.
>
>
> Any formal Acked-by, Reviewed-by or other will be appreciated. Comments
> and suggestions are also welcome.
>
> Thanks
> Emil
>
> [1]
> https://lists.freedesktop.org/archives/wayland-devel/2017-September/035019.html

Besides my concern in patch 1, the whole series is:
Reviewed-by: Arnaud Vrac <avrac at freebox.fr>

It does make porting new drivers an easier task, thanks !

-Arnaud

>
> Emil Velikov (8):
>   wayland-egl: import libwayland-egl.so frontend library from Mesa
>   wayland-egl: reuse the existing WL_EXPORT macro
>   wayland-egl: correct wayland-egl.pc description/version
>   wayland-egl: introduce wayland-egl-backend.pc
>   wayland-egl: add a note about keeping the backend version in sync
>   build: wire-up wayland-egl
>   wayland-egl-symbols-check: pass the DSO name via the build system
>   wayland-egl: move the wayland-egl{,-core}.h headers to egl/
>
>  Makefile.am                     |  28 ++++-
>  configure.ac                    |   2 +
>  egl/wayland-egl-abi-check.c     | 235 ++++++++++++++++++++++++++++++++++++++++
>  egl/wayland-egl-backend.h       |  67 ++++++++++++
>  egl/wayland-egl-backend.pc.in   |   9 ++
>  {src => egl}/wayland-egl-core.h |   0
>  egl/wayland-egl-symbols-check   |  16 +++
>  egl/wayland-egl.c               | 104 ++++++++++++++++++
>  {src => egl}/wayland-egl.h      |   0
>  egl/wayland-egl.pc.in           |  11 ++
>  10 files changed, 468 insertions(+), 4 deletions(-)
>  create mode 100644 egl/wayland-egl-abi-check.c
>  create mode 100644 egl/wayland-egl-backend.h
>  create mode 100644 egl/wayland-egl-backend.pc.in
>  rename {src => egl}/wayland-egl-core.h (100%)
>  create mode 100755 egl/wayland-egl-symbols-check
>  create mode 100644 egl/wayland-egl.c
>  rename {src => egl}/wayland-egl.h (100%)
>  create mode 100644 egl/wayland-egl.pc.in
>
> --
> 2.14.1


More information about the wayland-devel mailing list