[PATCH] linux-dmabuf: send deprecated format events

Philipp Zabel p.zabel at pengutronix.de
Fri Dec 15 10:46:26 UTC 2017

Hi Daniel,

On Fri, 2017-12-15 at 09:46 +0000, Daniel Stone wrote:
> Hi Michael and Philipp,
> On 15 December 2017 at 09:25, Philipp Zabel <p.zabel at pengutronix.de> wrote:
> > Although the format event is deprecated, some clients, especially the
> > GStreamer waylandsink, only support zwp_linux_dmabuf_v1 version 1 and
> > require the deprecated format event.
> > 
> > Send format events instead of the modifier event, if the client binds on
> > a protocol version before version 3, skipping formats that only support
> > non-linear modifiers.
> Thanks for this! Could I please persuade you to take on one additional
> change though?
> Specifically, if has_dmabuf_import_modifiers is not supported,
> gl-renderer will return 0 for num_formats. In this case, it seems like
> we should send a conservative list: ARGB8888, XRGB8888, and maybe
> speculatively the YUV formats we have hardcoded conversions for
> (provided we have R8/RG8 support, cf. the patches from Arnaud).

Should we modify gl_renderer_query_dmabuf_formats to return that list of
hardcoded formats if has_dmabuf_import_modifiers is not supported?


More information about the wayland-devel mailing list